-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/schematic options #149
Feat/schematic options #149
Conversation
Hey, I’m return in 2 days to work ... and i will review all.. thanks for all of this work 💪 |
Awesome. I will also work on providing some schematic tests |
See my comments and then I can approve. @d-koppenhagen |
@aaronfrost jep I will solve this later. Nonetheless a bit of docs and probably tests are missing. I will add them. Also there is still an ongoing discussion in #100 about more options for posts for configuring meta data. I think your opinion to the suggestions I made would be great to have. |
@jorgeucano i've also done a bit of refactoring and I added some more test specs. It would be good to check all this in detail and tests it again :) |
hey @ d-koppenhagen this is a great job! Thanks, can you describe all the changes in a list? ... I need this to test the functionalities |
Sure. I will do this later. |
I really love the idea, one of my next tasks is to start writing the test ... but, in this case, please add me the list and when we merge this ... we can create other pr ... I like a pr by functionality/issue/etc ... it is easier to test and work :) |
Yes you are probably right. Let's merge this and face tests and more functionality in separate MR's and issues. So here is the list:
|
…tions * upstream/master: feat(voidplugin): plugin that lets you exclude routes fix(scully readme): put readme back on npm feat(schematics): add support for nx monorepos (scullyio#162) Postrenderers addition (scullyio#160) chore(script): 🤖 add commit select for commit only the file the pr need (scullyio#158) improvement(scully): export built-in plugins (scullyio#153) feat(transferstateservice): Fix ngc error (scullyio#152)
@d-koppenhagen i created a little change for support nx with schematics, can you pull from master and merge :) after this i will Approve :) thanks for all of this work |
@jorgeucano already done 😃 see 4fd2cb0 |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: closes #100
What is the new behavior?
This PR will implement the options for schematics as discussed in #100
Does this PR introduce a breaking change?
Other information